Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eagon northcott complex #4327

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Eagon northcott complex #4327

wants to merge 7 commits into from
+1,032 −142

Conversation

HechtiDerLachs
Copy link
Collaborator

@HechtiDerLachs HechtiDerLachs commented Nov 18, 2024 •
edited
Loading

This is the branch with the full functionality for what's used in this preprint. I would like to bring these things to OSCAR, but piece by piece. The first round was in #4248 , so once that one is merged, I will rebase this PR again. For the moment, I would just like to work on the tests and polish this here a bit.

Ready for review. This introduces

  • strands of complexes of graded modules for ZZ^m-gradings
  • Eagon-Northcott complexes

@HechtiDerLachs HechtiDerLachs marked this pull request as draft November 18, 2024 13:56
lgoettgens
lgoettgens reviewed Nov 25, 2024
View reviewed changes
src/Modules/Iterators.jl Outdated Show resolved Hide resolved
src/Modules/Iterators.jl Outdated Show resolved Hide resolved
benlorenz
benlorenz reviewed Nov 25, 2024
View reviewed changes
src/Modules/Iterators.jl Outdated Show resolved Hide resolved
src/Modules/Iterators.jl Outdated Show resolved Hide resolved
@HechtiDerLachs HechtiDerLachs mentioned this pull request Nov 25, 2024
Closed
@HechtiDerLachs
Copy link
Collaborator Author

Tests are failing, but I can not reproduce a single one of these failures. Is any of these problems known? Ping @benlorenz @aaruni96

@HechtiDerLachs HechtiDerLachs marked this pull request as ready for review November 26, 2024 06:16
@HechtiDerLachs HechtiDerLachs marked this pull request as draft November 26, 2024 06:16
@HechtiDerLachs HechtiDerLachs mentioned this pull request Nov 26, 2024
Merged
@HechtiDerLachs HechtiDerLachs marked this pull request as ready for review November 26, 2024 06:55
@thofma
Copy link
Collaborator

thofma commented Nov 26, 2024

keys for generators (comprehensions) is not available on 1.6

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.98305% with 52 lines in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (4542bd3) to head (ed2cf5a).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
experimental/Schemes/src/DerivedPushforward.jl 30.64% 43 Missing ⚠️
src/Modules/Iterators.jl 96.82% 4 Missing ⚠️
...HyperComplexes/src/Objects/new_koszul_complexes.jl 93.18% 3 Missing ⚠️
...tal/DoubleAndHyperComplexes/src/Objects/Methods.jl 88.88% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4327      +/-   ##
==========================================
- Coverage   84.52%   84.33%   -0.19%     
==========================================
  Files         646      656      +10     
  Lines       85823    86875    +1052     
==========================================
+ Hits        72539    73268     +729     
- Misses      13284    13607     +323
Files with missing lines Coverage Δ
...perComplexes/src/Morphisms/simplified_complexes.jl 94.71% <100.00%> (ø)
...perComplexes/src/Morphisms/strand_functionality.jl 100.00% <100.00%> (ø)
...l/DoubleAndHyperComplexes/src/Morphisms/strands.jl 100.00% <100.00%> (ø)
...mplexes/src/Objects/cartan_eilenberg_resolution.jl 75.67% <100.00%> (ø)
...erComplexes/src/Objects/eagon_northcott_complex.jl 100.00% <100.00%> (ø)
...DoubleAndHyperComplexes/src/Objects/induced_ENC.jl 100.00% <100.00%> (ø)
...plexes/src/Objects/tensor_product_functionality.jl 100.00% <100.00%> (ø)
...leAndHyperComplexes/src/Objects/tensor_products.jl 90.56% <ø> (-0.67%) ⬇️
src/Modules/UngradedModules/HomologicalAlgebra.jl 92.81% <100.00%> (ø)
src/Modules/UngradedModules/Methods.jl 88.94% <100.00%> (+2.89%) ⬆️
... and 5 more

... and 20 files with indirect coverage changes

@HechtiDerLachs
Copy link
Collaborator Author

keys for generators (comprehensions) is not available on 1.6

Sorry, but I still do not understand what's going on here. I can not reproduce the error. You are talking about 1.6 of what? Oscar? Julia? Hecke? Nemo?

benlorenz
benlorenz reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to improve the coverage a bit

Attention: Patch coverage is 53.81356% with 218 lines in your changes missing coverage. Please review.

especially src/Modules/Iterators.jl where just 8% of the new code is tested.

experimental/DoubleAndHyperComplexes/src/Objects/eagon_northcott_complex.jl Outdated Show resolved Hide resolved
@HechtiDerLachs
Copy link
Collaborator Author

It would be good to improve the coverage a bit

Yes. I was thinking of putting the easier examples from my paper here as test files. That way people also have the possibility to reproduce the computations. Is this a legitimate approach? @JHanselman ?

@lgoettgens
Copy link
Member

It would be good to improve the coverage a bit

Yes. I was thinking of putting the easier examples from my paper here as test files. That way people also have the possibility to reproduce the computations. Is this a legitimate approach? @JHanselman ?

That would of course help. However, please then add a comment somewhere that these are more like regression tests aka you are not certain that the current result is correct, but you want failures if the result changes. And (if possible) please add some basic tests that can be either verified by hand or using other software (although this may be hard to do/impossible)

@benlorenz
Copy link
Member

One file with very low patch coverage is src/Modules/Iterators.jl, it should be easy to add some basic tests for iterating or counting some AllModuleMonomials and AllModuleExponents objects. Having separate tests for such code makes maintenance a lot easier than just testing this indirectly via some higher-level examples.

@HereAround
Copy link
Member

@wdecker seems interested, and will touch by next week (likely this week) with @HechtiDerLachs to discuss more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgoettgens lgoettgens lgoettgens left review comments

@benlorenz benlorenz benlorenz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HechtiDerLachs @thofma @lgoettgens @benlorenz @HereAround